From 4be05adb0c4c1b57a5f850312b8cdac30b6c5cce Mon Sep 17 00:00:00 2001
From: Tao Chen <42793494+IamTaoChen@users.noreply.github.com>
Date: Sun, 10 Aug 2025 11:15:48 +0800
Subject: [PATCH] =?UTF-8?q?feat:=20=E4=BC=98=E5=8C=96oauth=E8=AE=BE?=
 =?UTF-8?q?=E7=BD=AE=E9=A1=B5=E9=9D=A2=20(#22)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* hide ClientSecret when re-edit

* add rediret_url at oauth form(readonly, for user to know what's the redirect url)

* format defaultRedirect
---
 src/views/oauth/index.vue | 37 +++++++++++++++++++++++++++++--------
 1 file changed, 29 insertions(+), 8 deletions(-)

diff --git a/src/views/oauth/index.vue b/src/views/oauth/index.vue
index bdb86a1..95554ee 100644
--- a/src/views/oauth/index.vue
+++ b/src/views/oauth/index.vue
@@ -37,7 +37,7 @@
     </el-card>
     <el-dialog v-model="formVisible" :title="!formData.id?T('Create') :T('Update')" width="800">
       <el-form class="dialog-form" ref="form" :model="formData" :rules="rules" label-width="120px">
-        <el-form-item label="Type" prop="">
+        <el-form-item label="Type" prop="oauth_type">
           <el-radio-group v-model="formData.oauth_type" :disabled="!!formData.id">
             <el-radio v-for="item in types" :key="item.value" :value="item.value" style="display: block">
               {{ item.label }}
@@ -57,11 +57,21 @@
           <el-input v-model="formData.client_id"></el-input>
         </el-form-item>
         <el-form-item label="ClientSecret" prop="client_secret">
-          <el-input v-model="formData.client_secret"></el-input>
+          <el-input
+            v-model="formData.client_secret"
+            :type="formData.id ? 'password' : 'text'"
+            :show-password="!formData.id"
+            >
+          </el-input>
+        </el-form-item>
+        <el-form-item label="RedirectUrl" prop="redirect_url">
+          <el-input
+            v-model="formData.redirect_url"
+            readonly
+            suffix-icon="el-icon-document-copy"
+            @click="copyRedirectUrl"
+          />
         </el-form-item>
-<!--        <el-form-item label="RedirectUrl" prop="redirect_url">
-          <el-input v-model="formData.redirect_url"></el-input>
-        </el-form-item>-->
         <el-form-item label="PkceEnable" prop="pkce_enable">
           <el-switch v-model="formData.pkce_enable"
                      :active-value="true"
@@ -97,6 +107,12 @@
   import { ElMessage, ElMessageBox } from 'element-plus'
   import { T } from '@/utils/i18n'
 
+  const copyRedirectUrl = () => {
+    navigator.clipboard.writeText(formData.redirect_url)
+      .then(() => ElMessage.success('Copied'))
+      .catch(() => ElMessage.error('Copy failed'))
+  }
+
   const listRes = reactive({
     list: [], total: 0, loading: false,
   })
@@ -167,7 +183,7 @@
   const rules = {
     client_id: [{ required: true, message: T('ParamRequired', { param: 'client_id' }), trigger: 'blur' }],
     client_secret: [{ required: true, message: T('ParamRequired', { param: 'client_secret' }), trigger: 'blur' }],
-    redirect_url: [{ required: true, message: T('ParamRequired', { param: 'redirect_url' }), trigger: 'blur' }],
+    // redirect_url: [{ required: true, message: T('ParamRequired', { param: 'redirect_url' }), trigger: 'blur' }],
     oauth_type: [{ required: true, message: T('ParamRequired', { param: 'oauth_type' }), trigger: 'blur' }],
     issuer: [{ required: true, message: T('ParamRequired', { param: 'issuer' }), trigger: 'blur' }],
     pkce_method: [
@@ -185,6 +201,11 @@
       },
     ],
   }
+
+  const defaultRedirect = () => {
+    return `${window.location.origin}/api/oidc/callback`
+  }
+
   const toEdit = (row) => {
     formVisible.value = true
     formData.id = row.id
@@ -193,7 +214,7 @@
     formData.issuer = row.issuer
     formData.client_id = row.client_id
     formData.client_secret = row.client_secret
-    formData.redirect_url = row.redirect_url
+    formData.redirect_url = row.redirect_url || defaultRedirect()
     formData.scopes = row.scopes
     formData.auto_register = row.auto_register
     formData.pkce_enable = row.pkce_enable
@@ -207,7 +228,7 @@
     formData.issuer = ''
     formData.client_id = ''
     formData.client_secret = ''
-    formData.redirect_url = ''
+    formData.redirect_url = defaultRedirect()
     formData.scopes = ''
     formData.auto_register = false
     formData.pkce_enable = false